Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add provider eztv #8004

Merged
merged 29 commits into from
Apr 24, 2020
Merged

Feature/add provider eztv #8004

merged 29 commits into from
Apr 24, 2020

Conversation

JorgMuskens
Copy link
Contributor

Hi Guys,
I am referencing to #7508
I checked if there was any affiliation. As far as I could see and google there is none. The only thing I could find is.

EZTV was a TV-torrent distribution group founded in May 2005 and dissolved in April 2015, after a hostile takeover of their domains and brand by “EZCLOUD LIMITED”.

This popular torrent site continues to operate under new ownership (EZTV.io) and releases its own torrents now. Due to its controversial history, a large number of torrent sites have banned these ‘new’ releases from their sites.

EZTV has been blocked in many countries. however, it has managed to hold to the list of best torrent sites.

Here is a reddit thread about quote I stated
https://www.reddit.com/r/torrents/comments/40pzuf/is_it_safe_to_use_eztv_again_after_being_overtaken/

From my point of view it looks okay. Therefore i am opening a new pull request. Feel free to check it aswell. I am still using the same code for 5 months now without any problem. Hopefully this provider can be added as it is my favorite as i think for many others.
Best Regards
Jorg

Stay save

@medariox
Copy link
Contributor

Thanks for the PR! Looks good, can you just fix the lint errors? https://travis-ci.org/github/pymedusa/Medusa/jobs/678687560#L1937

@JorgMuskens
Copy link
Contributor Author

@medariox i am not sure where to begin. I never used travis-ci and when i open your link i see a lot of errors. Can you point me where to look? I am a newbie on this! If i now where to look i can investigate. The onyl this is that i am using python 3.7 and not 3.6.1. How would i tst the code? As in 3.7 i am not not getting errors. The only error i have is comming from subtitle finder since last master update. Please help

@duramato duramato changed the base branch from master to develop April 23, 2020 17:54
@JorgMuskens
Copy link
Contributor Author

I understand where to look now. will update in a moment

@p0psicles
Copy link
Contributor

There like three pep8 warnings left.

medusa/providers/torrent/json/eztv.py:14:1: I202 Additional newline in a group of imports. 'from medusa.helper.common import convert_size' is identified as Third Party and 'from medusa import tv' is identified as Third Party.
/home/travis/build/pymedusa/Medusa/medusa/providers/torrent/json/eztv.py:152:1: E305 expected 2 blank lines after class or function definition, found 1
/home/travis/build/pymedusa/Medusa/medusa/providers/torrent/json/eztv.py:153:1: W391 blank line at end of file

@JorgMuskens
Copy link
Contributor Author

JorgMuskens commented Apr 23, 2020 •
edited
Loading

I managed to fix those all seems ok now

medariox
medariox requested changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some little changes 👍

medusa/providers/torrent/json/eztv.py Outdated

if mode != 'RSS':
imdb_id = self.series.externals.get(mappings[10])
imdb_id = imdb_id[2:] # strip two tt's of id as they are not used by eztv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this after the if check below, as there are shows that don't have an imdb entry and it would cause an exception otherwise

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atually this can not be moved. Every show on eztv works based on imdb. So if a show has no IMDB the show will not be on EZTV. Therefor the else of the if statement shows log.debug('IMDb ID not found'). Please verify i do not have any shows without IMDB.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shows without IMDB will not be able to be search through the API. This how their API works see https://eztv.io/api/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive what he was saying is to move the slicing to right after the imdb_id check, so after line 68

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah because if returns null then errors out if sliced. makes sense!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed this in latest commit but travis is failing me 😕

JorgMuskens
JorgMuskens commented Apr 23, 2020
View reviewed changes
Copy link
Contributor Author

@JorgMuskens JorgMuskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the changes. But now restoring back because travis is failing again

@JorgMuskens
Copy link
Contributor Author

I just restored everything back to version that travis found ok but now the build is not working anymore. I do not understand why this is happening. I tried several commits to revert back but all changes have no effect, Can somebody please tell me what i am doing wrong?

@JorgMuskens
Copy link
Contributor Author

Can someone check the travis errors. It is i think not code related but command related ??

@OmgImAlexis
Copy link
Collaborator

This really shouldn’t be using the name but instead another with a warning. I feel it’s misleading to our users otherwise.

@p0psicles
Copy link
Contributor

I think Travis is down. Just try again later

@JorgMuskens
Copy link
Contributor Author

JorgMuskens commented Apr 24, 2020 •
edited
Loading

This really shouldn’t be using the name but instead another with a warning. I feel it’s misleading to our users otherwise.

@OmgImAlexis What do you mean? Can you elaborate what name is misleading other users?

@medariox medariox added this to the 0.3.16 milestone Apr 24, 2020
medariox
medariox approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks @JorgMuskens

@medariox medariox merged commit 41dcb7c into pymedusa:develop Apr 24, 2020
@JorgMuskens
Copy link
Contributor Author

Cool thanks to you guys.

@JorgMuskens
Copy link
Contributor Author

my old code contains the old eztv.io link which does not work anymore.
How can update to eztv.re??

@p0psicles
Copy link
Contributor

Update the base URL

@JorgMuskens
Copy link
Contributor Author

JorgMuskens commented Nov 9, 2020 •
edited
Loading

I hope i did it correctly as i opened new pr #8708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duramato duramato duramato left review comments

@p0psicles p0psicles p0psicles approved these changes

@medariox medariox medariox approved these changes

Assignees
No one assigned
Labels
Concluded
Projects
None yet
Milestone
0.3.16
Development

Successfully merging this pull request may close these issues.
5 participants
@JorgMuskens @medariox @p0psicles @OmgImAlexis @duramato