-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keep link as post processing method #7986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thank you!
Please update the test snapshots with yarn test -u
.
package.json
Outdated
@@ -14,5 +14,6 @@ | |||
}, | |||
"devDependencies": { | |||
"dredd": "12.2.1" | |||
} | |||
}, | |||
"version": "0.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the version
An entry in the changelog.md would be nice |
You'r right @p0psicles as well as updating the wiki but i don't know how edit the wiki Should i add an entry in changelog.md under the
Btw @medariox is my last commit good ? edit: |
Changelog is good! |
No need to merge develop. |
We link the number of the pr in the change log. Not the issue |
Awesome work, thanks! A Wiki entry is highly appreciated. |
Hi,
I hope I didn't make too many mistakes, the python workflow is very new to me.
Please don't hesitate to tell me what I did wrong if I did, I'd like to learn how to do things right thank you.
Related to this issue #6654