Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix size changed during iteration. #7956

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Fix size changed during iteration. #7956

merged 1 commit into from
Apr 12, 2020

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Apr 12, 2020 •
edited
Loading

dict.values() is a generator. So it can cause errors when the dict is changed during iteration.

Prevent this by casting to an array, before iterating. Most py2 backwards compatible solution.

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Fix for #7947

@p0psicles
Fix size changed during iteration.
b237875 
 `dict.values()` is a generator. So it can cause errors when the dict is changed during iteration.

Prevent this by casting to an array, before iterating. Most py2 backwards compatible solution.
@p0psicles p0psicles added the Bug label Apr 12, 2020
@p0psicles p0psicles added this to the 0.3.15 milestone Apr 12, 2020
@p0psicles p0psicles requested a review from medariox April 12, 2020 08:06
@medariox medariox merged commit 73d2834 into develop Apr 12, 2020
@medariox medariox deleted the feature/fix-dict-size-change-error branch April 12, 2020 11:42
@medariox medariox mentioned this pull request Apr 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medariox medariox medariox approved these changes

Assignees
No one assigned
Labels
Bug Concluded
Projects
None yet
Milestone
0.3.16
Development

Successfully merging this pull request may close these issues.
2 participants
@p0psicles @medariox