Added a spanish subtitle provider subtitulamos.tv #7518
Conversation
Fix syntax
|
Good job on this PR 👍 Can you please fix the flake issues |
Added medusa/subtitle_providers/subtitulamos.py.
Fixed the flake issues D204.
Fixed the flake issues W293.
|
Is it OK now? |
|
Yes, thank you! Will try to get this reviewed and merged in the next few days. |
|
Thanks a lot!!! |
|
|
||
| """ | ||
| # make the search | ||
| logger.info('%s: Searching episode url for %s, season %d, episode %d', self.__class__.__name__.upper(), series, season, episode) |
There was a problem hiding this comment.
I don't think it is necessary to prepend every provider log with the name. Looks like no other provider does it either. Please remove it from all the logs.
| r.raise_for_status() | ||
|
|
||
| if r.status_code != 200: | ||
| logger.error('%s: Error getting episode url', self.__class__.__name__.upper()) |
There was a problem hiding this comment.
Please make this warning instead.
| # get the episode url | ||
| episode_url = self._search_url_titles(series, season, episode, year) | ||
| if episode_url is None: | ||
| logger.warning('%s: No episode url found for %s, season %d, episode %d', self.__class__.__name__.upper(), series, season, episode) |
There was a problem hiding this comment.
I think making this warning is going to be too much. This might occur quite often, better to make it info.
| soup = ParserBeautifulSoup(r.content, ['lxml', 'html.parser']) | ||
|
|
||
| # get episode title | ||
| logger.info('%s: Getting episode title', self.__class__.__name__.upper()) |
| title_pattern = re.compile('{}x{:02d} - (.+)'.format(season, episode)) | ||
| title = title_pattern.search(soup.select('.episode-name')[0].get_text().strip().lower()).group(1) | ||
|
|
||
| logger.info('%s: Episode title found: "%s"', self.__class__.__name__.upper(), title.upper()) |
| logger.info('%s: Getting episode title', self.__class__.__name__.upper()) | ||
|
|
||
| title_pattern = re.compile('{}x{:02d} - (.+)'.format(season, episode)) | ||
| title = title_pattern.search(soup.select('.episode-name')[0].get_text().strip().lower()).group(1) |
There was a problem hiding this comment.
Please use get_text(strip=True) instead of get_text().strip(). Also for the other occurrences.
| # ignore incomplete subtitles | ||
| status = sub.find_next('div', class_='subtitle_buttons').contents[1] | ||
| if status.name != 'a': | ||
| logger.info('%s: Ignoring subtitle in [%s] not finished', self.__class__.__name__.upper(), language) |
There was a problem hiding this comment.
It's not very clear why the status.name should be a. Please explain what is going on here and improve the logger message.
Minor changes made.
|
Sorry for the delay, but I was on Christmas holidays. |
Problem with tabs resolved.
|
No worries, same here. Can you remove the master branch protection? So I can make a few final changes, see: https://help.github.com/en/github/administering-a-repository/configuring-protected-branches |
|
I think I have remove the protection. Is it ok? |
|
Nope, sadly I can't even push a new branch to your repository. 😢 |
|
Hi, sorry about the protection issue. |
Added a spanish subtitle provider subtitulamos.tv