Feature/fix behondhd #7323
Merged
Feature/fix behondhd #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
p0psicles
commented
Nov 8, 2019
•
p0psicles
commented
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
* skip <tr> with one td.
p0psicles
commented
Nov 8, 2019
| .format(provider_url=self.name, required_cookies=self.required_cookies) | ||
| } | ||
| if self.required_cookies: | ||
| if self.name != 'Beyond-HD': |
There was a problem hiding this comment.
For now beyond-hd is the only one with a cookie name like: remember_web_59ba36addc2b2f9401580f01445acd8ea4e30af9d. So I had to make an exception for this provider.
p0psicles
commented
Nov 8, 2019
| @@ -111,14 +112,17 @@ def parse(self, data, mode): | |||
| cells = result('td') | |||
|
|
|||
| try: | |||
| link = cells[1].find('div') | |||
| if len(cells) < 2: | |||
There was a problem hiding this comment.
There is an hidden tr at the end with one td.
This comment has been minimized.
This comment has been minimized.
* Modified the previous
medariox
approved these changes
Nov 8, 2019
|
Hey. I'm getting the error: [80b323e] Cookie is not correctly formatted: **********. I'm just copying and pasting the "remember_web_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" from BHD. Am I doing something wrong? Thanks! |
|
It's key=value. You probably only have the key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.