Vueify log viewer (and use Backstretch) #6738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkykh
added
In progress
Do not merge
Changelog
Open
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
sharkykh
added
Concluded
and removed
Changelog
This comment has been minimized.
This comment has been minimized.
p0psicles
approved these changes
May 29, 2019
|
nice PR! |
|
Many thanks |
Thilas
pushed a commit
to Thilas/Medusa
that referenced
this pull request
Jun 5, 2019
* Update backstretch component and use it * Add `logs.debug`/`logs.dbDebug` to config * Move dynamic imports in `router.js` * Convert `/errorlogs/viewlog` to Vue/SFC/API * Add `thread: "VUE"` option to `POST /api/v2/log` * Add Logs render test * Fix logs viewer visual bug https://i.imgur.com/tP21MW2.jpg * Fix tests * Update dredd hook to print to a log file because nothing prints to `stdout` * Fix log test * Update test_log.py * Fix spacing in fixture * Update CHANGELOG.md * Should fix `THREAD` != `Thread`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4104
It's basically done!
Looks like I just need to fix the tests.
Edit: Also push the fix for this bug.