Remove old regex pattern from CensoredFormatter
#6705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newznab used to be a long string, and didn't have actual config sections, but that's changed now. So now when newznab/torznab providers and loaded, the API key gets added to the censored items list. The other reason for removing this is because the pattern isn't very accurate and can cause issues with logs (noticed this with a log from `tornado`)
sharkykh
force-pushed
the
bugfix/censor-api-pattern
branch
from
3045c78 to
90b3fd8
Compare
medariox
approved these changes
May 20, 2019
Thilas
pushed a commit
to Thilas/Medusa
that referenced
this pull request
Jun 5, 2019
* Remove old regex pattern from `CensoredFormatter` Newznab used to be a long string, and didn't have actual config sections, but that's changed now. So now when newznab/torznab providers and loaded, the API key gets added to the censored items list. The other reason for removing this is because the pattern isn't very accurate and can cause issues with logs (noticed this with a log from `tornado`) * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newznab used to be a long string (
NEWZNAB_DATA), and didn't have actual config sections, but that's changed now (#2970).So now when
newznab/torznabproviders and loaded, the API key gets added to the censored items list.The other reason for removing this is because the pattern isn't very accurate and can cause issues with logs.
For example, I noticed this with a log from
tornado: https://regex101.com/r/09dy7L/3You can see the different variations in which
apikeyis sometimes first, sometimes last, sometimes the only parameter,And whatever is matched as "Group 2" (in red), will is replaced with asterisks (*)