Fix API v2 exception on incorrect API key. Fixes #5425

[sharkykh]

Fixes #5425, added 2 small tests for that
Fixes RESTful HTTPErrors causing real exceptions.

[ghost]

DeepCode analyzed this pull request.
There are no new issues. 1 info report was fixed.

Click to see more details.

[sharkykh]

Working on implementing a couple of tests, and another small bug:

Traceback (most recent call last):
  File "C:\Dev\Medusa\ext\tornado\web.py", line 1559, in _execute
    raise HTTPError(405)
tornado.web.HTTPError: HTTP 405: Method Not Allowed

[p0psicles]

Ooh then ignore my approval

[sharkykh]

Sorry, took me a while to figure all of this stuff out. I think the code for the multi-threaded API looks much better now.
For the record -
#5425 - The issue was with the prepare method.
HTTPError - A combination of things, I rewrote the error handling code. Like I said above, should be much better now.

edit: oh come on...

[sharkykh]

All good now.

[p0psicles]

Your kinda asuming that the method call cant raise exceptions?

[sharkykh]

I'll try to explain as best I can.
Basically - yes.
But the difference is the RequestHandler class has an exception handler, and we handle everything in write_error now.

Medusa/medusa/server/api/v2/base.py

Lines 151 to 165 in 91140e1

	def write_error(self, status_code, *args, **kwargs):
	"""Only send traceback if app.DEVELOPER is true."""
	response = None
	exc_info = kwargs.get('exc_info', None)
	if exc_info and isinstance(exc_info[1], HTTPError):
	error = exc_info[1].log_message or exc_info[1].reason
	response = self.api_response(status=status_code, error=error)
	elif app.DEVELOPER and exc_info:
	self.set_header('content-type', 'text/plain')
	self.set_status(500)
	for line in traceback.format_exception(*exc_info):
	self.write(line)
	else:
	response = self._internal_server_error()

HTTPErrors are handled as RESTful responses,
And anything other than HTTPError is handled as an actual exception and sends "Internal Server Error" as the response (or the traceback, if app.DEVELOPER is enabled, like before)

[sharkykh]

Your kinda asuming that the method call cant raise exceptions?

Sorry, I actually misread that.
Quite the opposite, I plan on it, but as I explained in the comment above, it's all being handled (just in one location and not everywhere)

[sharkykh]

Retry Deepcode

[ghost]

DeepCode analyzed this pull request.
There is 1 new info report. 1 warning and 2 info reports were fixed.

Click to see more details.