Update requirements #6628
Merged
Update requirements #6628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkykh
force-pushed
the
feature/update-requirements
branch
4 times, most recently
from
de03520 to
c8986d9
Compare
- Remove `oauth2` from `requirements.txt` - Fix `adba` commit - Fix `cfscrape` package name - Fix `subliminal` commit - Fix `deluge-client` module - Add markers for some dependencies
Use `tar.gz` archives from `codeload.github.com` instead of git. Should be faster and lighter.
- Move `singledispatch` to `ext2`
Anything for Python versions below 3.4 is Python 2.7 in our case
- Move `backports_abc` to `ext2`
Anything for Python versions below 3.5 is Python 2.7 in our case
Use `folder` to apply markers when generating `requirements.txt`
To only contain: - Packages directly imported/used by `medusa` - Git dependencies
See `medusa/init/__init__.py`: `_check_python_version` executes first
sharkykh
force-pushed
the
feature/update-requirements
branch
from
c8986d9 to
de50d12
Compare
Thilas
pushed a commit
to Thilas/Medusa
that referenced
this pull request
Jun 5, 2019
* Update dependency lists:
- Remove `oauth2` from `requirements.txt`
- Fix `adba` commit
- Fix `cfscrape` package name
- Fix `subliminal` commit
- Fix `deluge-client` module
- Add markers for some dependencies
* Update `_check_python_version` to disallow `< 3.5`
* Better requirement URLs for github deps
Use `tar.gz` archives from `codeload.github.com` instead of git.
Should be faster and lighter.
* Reorder columns (remove `Status`)
* Sort lists by package name
* Move all packages for Python < 3.5 into `ext2`:
- Move `singledispatch` to `ext2`
Anything for Python versions below 3.4 is Python 2.7 in our case
- Move `backports_abc` to `ext2`
Anything for Python versions below 3.5 is Python 2.7 in our case
* Remove markers from list
Use `folder` to apply markers when generating `requirements.txt`
* Update `requirements.txt` based off of list
To only contain:
- Packages directly imported/used by `medusa`
- Git dependencies
* Remove unreachable code
See `medusa/init/__init__.py`:
`_check_python_version` executes first
* Fix `validators` version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauth2fromrequirements.txtadbacommitcfscrapepackage namesubliminalcommitdeluge-clientmodule_check_python_versionto disallow< 3.5Use
tar.gzarchives fromcodeload.github.cominstead of git.Should be faster and lighter.
Status)ext2:singledispatchtoext2backports_abctoext2Move contextlib2 to ext2Used everywhere regardless of Python versionUse
folderto apply markers when generatingrequirements.txtrequirements.txtbased off of list to only contain:medusamedusa/init/__init__.py:_check_python_versionexecutes first.validatorsversionFYI, I am using medusa_vendor_tools to parse and generate
requirements.txtfrom this list and sort the list by the package name.