Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email notifier name parser. Fixes #6526 #6527

Merged
merged 2 commits into from
Apr 17, 2019

Conversation

sharkykh
Copy link
Contributor

@sharkykh sharkykh commented Apr 16, 2019

Fixes #6526

It seems like I made a mistake when I wrote the parser (#4450).
%AD uses spaces, not dashes:

Medusa/medusa/tv/episode.py

Lines 1542 to 1545 in 532abfa

'%AD': str(self.airdate).replace('-', ' '),
'%A.D': str(self.airdate).replace('-', '.'),
'%A_D': us(str(self.airdate)),
'%A-D': str(self.airdate),

# Before:
from medusa.notifiers.emailnotify import Notifier
Notifier._parse_name('Jeopardy! - 2019 04 15 - Returning Champion Vs. , show # 7971 - 720p HDTV')
# WARNING:medusa.notifiers.emailnotify:Unable to parse "Jeopardy! - 2019 04 15 - Returning Champion Vs. , show # 7971 - 720p HDTV" for email notification
{'show': 'Jeopardy!', 'episode': '2019 04 15 - Returning Champion Vs. , show # 7971 - 720p HDTV'}

# After:
from medusa.notifiers.emailnotify import Notifier
Notifier._parse_name('Jeopardy! - 2019 04 15 - Returning Champion Vs. , show # 7971 - 720p HDTV')
{'show': 'Jeopardy!', 'ep_id': '2019 04 15', 'episode': 'Returning Champion Vs. , show # 7971 - 720p HDTV'}

@sharkykh sharkykh added the Bug label Apr 16, 2019
@sharkykh sharkykh added this to the 0.3.2 milestone Apr 16, 2019
@sharkykh sharkykh force-pushed the bugfix/emailnotifier-parser branch from 40a8c52 to 4541fec Compare April 16, 2019 21:32
@medariox medariox merged commit 81c5604 into develop Apr 17, 2019
@medariox medariox deleted the bugfix/emailnotifier-parser branch April 17, 2019 13:26
Thilas pushed a commit to Thilas/Medusa that referenced this pull request Jun 5, 2019
* Fix email notifier name parser

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants