-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perfect match for subtitles is too strict #5740
Perfect match for subtitles is too strict #5740
Conversation
DeepCode analyzed this pull request. |
@medariox, could you review this PR? |
@medariox, I'm confused: I only changed the perfect match option to make it less strict. I mean that with the current perfect match, from what I understand, it already didn't download subtitles in such cases like the one you mention for |
Maybe it was there other way around, lowering the score makes it download wrong subtitles even with perfect match? Oh well, I would say we try it out and see how it turns out. |
@Thilas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a good idea to at least add a changelog? So its visible to users.
5d9711f
to
7e1be45
Compare
@medariox, @p0psicles, here is the changelog. |
Change perfect match in order to make it less strict as discussed in #5729.