Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfect match for subtitles is too strict #5740

Merged
merged 2 commits into from
Nov 20, 2018

Conversation

Thilas
Copy link
Contributor

@Thilas Thilas commented Nov 18, 2018

Change perfect match in order to make it less strict as discussed in #5729.

@ghost
Copy link

ghost commented Nov 18, 2018

DeepCode analyzed this pull request.
There are no new issues.

@Thilas
Copy link
Contributor Author

Thilas commented Nov 18, 2018

@medariox, could you review this PR?

@medariox
Copy link
Contributor

Thanks for the PR!
The problem with this is that some providers like LegendasTV group the release groups together, like: img
I understand your reasoning behind this, but it will cause a lot of users that use LegandasTV to complain about subs not being downloaded. Maybe there is some other way to do this e.g. using the language instead of release group?

@Thilas
Copy link
Contributor Author

Thilas commented Nov 19, 2018

@medariox, I'm confused: I only changed the perfect match option to make it less strict. I mean that with the current perfect match, from what I understand, it already didn't download subtitles in such cases like the one you mention for LegendasTV. And I guess it also wouldn't with my change. So the only way for users is to use non-perfect match here, which I didn't change. Am I wrong?

@medariox
Copy link
Contributor

Maybe it was there other way around, lowering the score makes it download wrong subtitles even with perfect match? Oh well, I would say we try it out and see how it turns out.

medariox
medariox previously approved these changes Nov 20, 2018
@medariox
Copy link
Contributor

@Thilas
Can you update the changelog please? I would add this to improvements.

Copy link
Contributor

@p0psicles p0psicles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a good idea to at least add a changelog? So its visible to users.

@Thilas
Copy link
Contributor Author

Thilas commented Nov 20, 2018

@medariox, @p0psicles, here is the changelog.

@p0psicles p0psicles merged commit c493445 into pymedusa:develop Nov 20, 2018
@Thilas Thilas deleted the fix/perfect-match-too-strict branch November 20, 2018 22:16
@Thilas Thilas mentioned this pull request Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants