Fix show-selector for libraries with more than 1k shows #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DeepCode analyzed this pull request. |
sharkykh
changed the title
p0psicles
approved these changes
Nov 4, 2018
OmgImAlexis
approved these changes
Nov 4, 2018
OmgImAlexis
reviewed
Nov 5, 2018
| @@ -319,7 +319,7 @@ def _get_page(self): | |||
| except ValueError: | |||
| self._raise_bad_request_error('Invalid page parameter') | |||
|
|
|||
| def _get_limit(self, default=20, maximum=1000): | |||
| def _get_limit(self, default=20, maximum=10000): | |||
There was a problem hiding this comment.
@sharkykh the one problem with this approach that we're now skipping pagination. Maybe we should open an issue about this so we don't forget?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5240