Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix save multiple metadata providers #5576

Merged
merged 3 commits into from
Nov 3, 2018
Merged

Fix save multiple metadata providers #5576

merged 3 commits into from
Nov 3, 2018

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Oct 31, 2018 •
edited
Loading

…u can't configure a second provider, after saving one.

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@p0psicles
Disable selectFirstEnabledMetadataProvider. As it has a bug, where yo…
3130833 
…u can't configure a second provider, after saving one.
@ghost
Copy link

ghost commented Oct 31, 2018

DeepCode analyzed this pull request.
There are no new issues.

@p0psicles p0psicles changed the title Disable selectFirstEnabledMetadataProvider. As it has a bug, where yo… Fix save multiple metadata providers Oct 31, 2018
sharkykh
sharkykh approved these changes Nov 3, 2018
View reviewed changes
Copy link
Contributor

@sharkykh sharkykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, did not test

@p0psicles p0psicles merged commit cd9f948 into develop Nov 3, 2018
@p0psicles p0psicles deleted the feature/fix-saving-multiple-metadata-providers branch November 3, 2018 14:04
@sharkykh sharkykh added this to the 0.2.12 milestone Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkykh sharkykh sharkykh approved these changes

Assignees
No one assigned
Labels
Bug Concluded Confirmed
Projects
None yet
Milestone
0.2.12
Development

Successfully merging this pull request may close these issues.
2 participants
@p0psicles @sharkykh