Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config/notifications page after breaking it in vueifying #5557

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Fix config/notifications page after breaking it in vueifying #5557

merged 4 commits into from
Oct 31, 2018

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Oct 30, 2018 •
edited
Loading

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@OmgImAlexis you can put additional changes in here. But this commit is needed to get config/notificatons working again.

@ghost
Copy link

ghost commented Oct 30, 2018

DeepCode analyzed this pull request.
There are no new issues.

@p0psicles
config-notifications: Use v-model in stead of value with @update = $e…
95e858f 
…vent, for config-* components.
@p0psicles
Fix config-* components.
ce0d7fa 
* Had to use this.$emit in stead of destructuring it.
* Fixed saving email.port.
@p0psicles p0psicles mentioned this pull request Oct 31, 2018
Merged
3 tasks
@p0psicles p0psicles changed the title Move @update event from watch to @change. Fix config/notifications page after breaking it in vueifying Oct 31, 2018
@p0psicles p0psicles requested a review from OmgImAlexis October 31, 2018 09:40
OmgImAlexis
OmgImAlexis approved these changes Oct 31, 2018
View reviewed changes
Copy link
Collaborator

@OmgImAlexis OmgImAlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmgImAlexis OmgImAlexis added this to the 0.2.12 milestone Oct 31, 2018
@OmgImAlexis OmgImAlexis merged commit 1f06ce4 into develop Oct 31, 2018
@OmgImAlexis OmgImAlexis deleted the feature/fix-config-components branch October 31, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmgImAlexis OmgImAlexis OmgImAlexis approved these changes

Assignees
No one assigned
Labels
Bug Concluded Frontend
Projects
None yet
Milestone
0.2.12
Development

Successfully merging this pull request may close these issues.
2 participants
@p0psicles @OmgImAlexis