Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vueify config search #5553

Merged
merged 20 commits into from
Nov 16, 2018
Merged

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Oct 29, 2018

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

TODO:

  • Update api-description
  • changelog.md
  • Fix build
  • Save clients (add to config.py patch method).

image

@ghost
Copy link

ghost commented Oct 29, 2018

DeepCode analyzed this pull request.
There are no new issues.

…eify-config-search

# Conflicts:
#	themes/dark/assets/js/medusa-runtime.js
#	themes/light/assets/js/medusa-runtime.js
* Added search state
* Fixed config-textbox and config-toggle-slider.vue (merge from 5557)
@ghost
Copy link

ghost commented Oct 30, 2018

DeepCode analyzed this pull request.
There are no new issues.

* Added clients module to state.
…eify-config-search

# Conflicts:
#	themes-default/slim/src/components/helpers/config-textbox-number.vue
#	themes-default/slim/src/components/helpers/config-textbox.vue
#	themes/dark/assets/js/medusa-runtime.js
#	themes/light/assets/js/medusa-runtime.js
@ghost
Copy link

ghost commented Oct 31, 2018

DeepCode analyzed this pull request.
There are no new issues.

@ghost
Copy link

ghost commented Nov 1, 2018

DeepCode analyzed this pull request.
There are no new issues.

…eify-config-search

# Conflicts:
#	CHANGELOG.md
#	themes/dark/assets/js/medusa-runtime.js
#	themes/light/assets/js/medusa-runtime.js
@ghost
Copy link

ghost commented Nov 5, 2018

DeepCode analyzed this pull request.
There are no new issues.

@p0psicles p0psicles added this to the 0.2.12 milestone Nov 5, 2018
@OmgImAlexis OmgImAlexis self-requested a review November 5, 2018 11:19
* Added ava test for config-textbox-number.spec.js
* Updated snapshots.
@ghost
Copy link

ghost commented Nov 15, 2018

DeepCode analyzed this pull request.
There is 1 new info report.

Click to see more details.

…eify-config-search

# Conflicts:
#	CHANGELOG.md
@ghost
Copy link

ghost commented Nov 15, 2018

DeepCode analyzed this pull request.
There is 1 new info report.

Click to see more details.

@OmgImAlexis OmgImAlexis merged commit 8a56a7b into develop Nov 16, 2018
@OmgImAlexis OmgImAlexis deleted the feature/vueify-config-search branch November 16, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants