Fix database always trying to update #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
medariox
commented
Oct 29, 2018
medariox
commented
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
|
DeepCode analyzed this pull request. |
medariox
commented
Oct 29, 2018
| def checkDBVersion(self): | ||
| return self.connection.checkDBVersion() | ||
| def checkMajorDBVersion(self): | ||
| return self.connection.checkDBVersion()[0] |
There was a problem hiding this comment.
self.connection.checkDBVersion() returns a tuple like: (41, 11)
(41, 11) >= 42 -> True
sharkykh
reviewed
Oct 29, 2018
| return self.connection.version | ||
|
|
||
| def execute(self): | ||
| utils.backup_database(self.connection.path, self.checkDBVersion()) | ||
| utils.backup_database(self.connection.path, self.checkMajorDBVersion()) |
There was a problem hiding this comment.
I don't think these (the backup calls) should be changed.
Don't you need the tuple so that the database backup contains the minor version too?
There was a problem hiding this comment.
I think that's okay, because these backups are going to be of very old versions (< 42) and won't have a minor version anyway. The new versions are using self.connection.version which contains the major and minor version.
p0psicles
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.