Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bootstrap add new show #5509

Merged
merged 6 commits into from
Oct 29, 2018
Merged

Feature/bootstrap add new show #5509

merged 6 commits into from
Oct 29, 2018

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Oct 25, 2018 •
edited
Loading

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide
  • Test chrome
  • Test Firefox
  • Test edge
  • update changelog
  • fix build

old:
image

new:
image

@p0psicles
Made add-new-show responsive.
8f707e6 
With allot of css hacking.
Need to run tests on the supported browsers.
@p0psicles
fix color for light theme.
bc63697
@p0psicles
Fixed width for chrome and firefox.
c267049
@p0psicles
Fixed lint-css warnings.
26d08cc 
Replaced maring-left with padding-right.
Makes it align better, when floating to next row.
@p0psicles
Added changelog.
7f9dd22
@p0psicles
Finally was able to build the theme.
61a7338
@p0psicles
Copy link
Contributor Author

@OmgImAlexis wanna check this one out?

OmgImAlexis
OmgImAlexis approved these changes Oct 28, 2018
View reviewed changes
Copy link
Collaborator

@OmgImAlexis OmgImAlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest checking Chrome + FF just to be sure but looks good to me.

@p0psicles p0psicles merged commit e6a7958 into develop Oct 29, 2018
@p0psicles p0psicles deleted the feature/bootstrap-add-new-show branch October 29, 2018 05:12
@OmgImAlexis OmgImAlexis added this to the 0.2.11 milestone Oct 29, 2018
@sharkykh sharkykh mentioned this pull request Nov 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmgImAlexis OmgImAlexis OmgImAlexis approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
0.2.11
Development

Successfully merging this pull request may close these issues.
2 participants
@p0psicles @OmgImAlexis