Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saving of the config - postprocess frequency. #5482

Merged
merged 11 commits into from
Oct 25, 2018
Merged

Fix saving of the config - postprocess frequency. #5482

merged 11 commits into from
Oct 25, 2018

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Oct 24, 2018 •
edited
Loading

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@ghost
Copy link

ghost commented Oct 24, 2018

DeepCode analyzed this pull request and found no issues.

@p0psicles
Update CHANGELOG.md
7d35881 
Moved config/search to improvements.
@pymedusa pymedusa deleted a comment Oct 24, 2018
@pymedusa pymedusa deleted a comment Oct 24, 2018
@p0psicles
Copy link
Contributor Author

@medariox you know whats going on with the flake test?

@pymedusa pymedusa deleted a comment Oct 24, 2018
@medariox
Copy link
Contributor

@p0psicles
The new version of pycodestyle has some new rules, including W605 invalid escape sequence and W504 line break after binary operator. I've fixed W605 and excluded W504 for now.

@p0psicles
Copy link
Contributor Author

Youve excluded 605

medariox and others added 2 commits October 24, 2018 22:22
@medariox
Exclude W504 for real
bd01c1e
@p0psicles
Remove blank line.
481af06 
Don't know if this is the issue. Just trying some things.
@p0psicles
Copy link
Contributor Author

@sharkykh it says i need to build development.
But I did, yarn dev. And there's nothing left to build?

Done in 1.43s.
Please build the themes (mode: development) 
--------------------------------------------
 M themes/dark/assets/js/vendors.js
 M themes/light/assets/js/vendors.js

@medariox
Copy link
Contributor

@p0psicles Make sure to run yarn install before yarn dev.

@medariox medariox added this to the 0.2.11 milestone Oct 25, 2018
@medariox medariox mentioned this pull request Oct 25, 2018
Closed
@p0psicles p0psicles merged commit 707cce2 into develop Oct 25, 2018
@p0psicles p0psicles deleted the feature/fix-pp-frequency branch October 25, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medariox medariox medariox approved these changes

Assignees
No one assigned
Labels
Bug Concluded
Projects
None yet
Milestone
0.2.11
Development

Successfully merging this pull request may close these issues.
2 participants
@p0psicles @medariox