Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/vueify home #5345

Merged
merged 103 commits into from
May 21, 2020
Merged

Feature/vueify home #5345

merged 103 commits into from
May 21, 2020

Conversation

OmgImAlexis
Copy link
Collaborator

@OmgImAlexis OmgImAlexis commented Oct 2, 2018 •
edited by p0psicles
Loading

Closes: #5311

This converts the simple, banner and poster layouts over to Vue. The other layouts are still loaded via their corresponding mako files.

TODO:

  • convert air prev/next to Vue
  • convert XEM to Vue
  • convert poster layout to Vue
@p0psicles would you mind reviewing the poster layout once I add that?

Known issues:

  • For the table layouts, "select columns" is not working
  • Switching from displayShow to home, part of the displayShow overlay is shown
  • Switching from displayShow to home, error with "cannot read property epTotal of undefined" (need to get stats on route change)
  • Poster size slider not visible / working
  • Loading the poster layout, shows the "ugly" grey boxes, before images are loaded
  • Poster UI components not saved (working)
  • Folder selection not working (change from jquery to vue)
  • Themes not working. (currently developed against light theme)
  • Style vue-nav-tab dark layout (currently same is light)
  • Switching vue-nav-tabs, the switched to tab, does not have the minimum height of the posters
  • vue-nav-tabs: switching to second (non-init) tab does not show size-slider, when used with posters.
  • Store table sorting for banner, simple and small poster layouts

@OmgImAlexis
first run at banner
c77a3e4 
Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis
fix column sorter
6199e49 
Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis
remap stats into showList
07e0b44 
Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis
fix show size being undefined
d8e8bbc 
Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis
replaced downloadStats with progress bar component
a2cce69 
Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis
removed jQuery from progress-bar, moved banner to own file and starte…
439891a 
…d on simple layout

Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis
load banner directly in home layout
9c6e0a0 
Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis
fix allowed & preferred qualities
be6b1cd 
Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis
switch simple home layout to vue
e8700bd 
Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis
fix series listType with tabs
70b3e3b 
Signed-off-by: Alexis Tyler <[email protected]>
@OmgImAlexis OmgImAlexis added this to the 0.2.11 milestone Oct 2, 2018
@OmgImAlexis OmgImAlexis modified the milestones: 0.2.11, 0.2.12 Oct 29, 2018
@p0psicles
Merge remote-tracking branch 'remotes/origin/develop' into feature/vu…
1df983f 
…eify-home

# Conflicts:
#	themes-default/slim/package.json
#	themes-default/slim/src/components/home.vue
#	themes-default/slim/src/components/index.js
#	themes/dark/assets/js/medusa-runtime.js
#	themes/light/assets/js/medusa-runtime.js
@p0psicles
Tried fixing the build.
8b944d8 
Still a number of errors in it, because of the move to ./helpers.
@ghost
Copy link

ghost commented Nov 2, 2018

DeepCode analyzed this pull request.
There is 1 new info report.

Click to see more details.

OmgImAlexis and others added 2 commits November 2, 2018 20:53
@OmgImAlexis
fix imports/exports
b7b91ca 
Signed-off-by: Alexis Tyler <[email protected]>
@p0psicles
Merge remote-tracking branch 'remotes/origin/develop' into feature/vu…
cf4005a 
…eify-home

# Conflicts:
#	themes/dark/assets/js/medusa-runtime.js
#	themes/light/assets/js/medusa-runtime.js
@OmgImAlexis OmgImAlexis self-assigned this Nov 27, 2018
@p0psicles p0psicles mentioned this pull request Jan 9, 2019
Open
38 tasks
@p0psicles p0psicles mentioned this pull request Oct 23, 2019
Closed
@p0psicles
Merge remote-tracking branch 'origin/develop' into feature/vueify-home
00023be 
# Conflicts:
#	themes-default/slim/package.json
#	themes-default/slim/src/components/helpers/index.js
#	themes-default/slim/src/components/helpers/quality-pill.vue
#	themes-default/slim/src/components/home.vue
#	themes-default/slim/src/store/index.js
#	themes-default/slim/src/store/modules/defaults.js
#	themes-default/slim/src/store/modules/index.js
#	themes-default/slim/src/store/modules/stats.js
#	themes-default/slim/src/store/mutation-types.js
#	themes-default/slim/views/home.mako
#	themes-default/slim/views/partials/home/banner.mako
#	themes-default/slim/views/partials/home/simple.mako
#	themes-default/slim/views/vue-components/quality-chooser.mako
#	themes-default/slim/yarn.lock
#	themes/dark/assets/js/medusa-runtime.js
#	themes/dark/templates/home.mako
#	themes/dark/templates/partials/home/banner.mako
#	themes/dark/templates/partials/home/simple.mako
#	themes/dark/templates/vue-components/quality-chooser.mako
#	themes/light/assets/js/medusa-runtime.js
#	themes/light/templates/home.mako
#	themes/light/templates/partials/home/banner.mako
#	themes/light/templates/partials/home/simple.mako
#	themes/light/templates/vue-components/quality-chooser.mako
@p0psicles
Copy link
Contributor

I'm finishing this next

@p0psicles
Copy link
Contributor

@OmgImAlexis can you give me a short introduction on the idea behind the PR. And the order in which you where implementing. It could save me some time. Maybe spend 10minutes on discord?

@p0psicles
Copy link
Contributor

Hmm last build issue is because I foobar'd with the vue-good-table yarn dependency.
I had to rebase all my changes in from vue-good-table@git+https://github.com/p0psicles/vue-good-table#5cf396f70a5cee003d2541af381f87d4797a7a92 against vue-good-table@git+https://github.com/xaksis/vue-good-table#master.

In the process, I force pushed my changes onto my master branch.
But.. now the travis build slaves have the old "vue-good-table` dependency in it's cache, and this new commit does not merge nicely, so leaves conflicts.

At this time, I don't know how to fix this, other then, 1. add a cache clean command prior to the command, or 2. create a new branch, other then master?

@p0psicles
Copy link
Contributor

@sharkykh @medariox any ideas?

@medariox medariox modified the milestones: 0.2.12, 0.3.17 May 15, 2020
medariox
medariox reviewed May 16, 2020
View reviewed changes
medusa/server/api/v2/stats.py Outdated Show resolved Hide resolved
medusa/server/web/home/handler.py Outdated Show resolved Hide resolved
medusa/tv/series.py Outdated Show resolved Hide resolved
medusa/tv/series.py Outdated Show resolved Hide resolved
medusa/tv/series.py Outdated Show resolved Hide resolved
medusa/tv/series.py Outdated Show resolved Hide resolved
p0psicles added 7 commits May 16, 2020 20:23
@p0psicles
Improve show loading.
aa476a1 
Make sure all api/v2/series.py calls are handled throug the Promise.all() method.
* Added component load-progress-bar.vue.
@p0psicles
Fix bug non-vue routes not loading anymore.
0ea928e 
* Removed dark style for the load-progress-bar.
@p0psicles
Move shared vue code for the show-list table layouts, to a dedicated …
2d5c9c8 
…mixin.

* Created a new root mixins folder.
@p0psicles
import error
2ef2fa2
@p0psicles
Improve date sorting for small, simple and banner.
809ca27
@p0psicles
implemented review comments
677572a
@p0psicles
Save column sorting for simple.vue, smallposter.vue and banner.vue la…
f472313 
…youts in cookie.
@p0psicles p0psicles merged commit 0b346d6 into develop May 21, 2020
@p0psicles p0psicles deleted the feature/vueify-home branch May 21, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles left review comments

@medariox medariox medariox approved these changes

Assignees
No one assigned
Labels
Concluded Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmgImAlexis @p0psicles @medariox