-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vueify restart, move js files to vue, add state-switch & more #5159
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
39781f8
displayShow -> show
OmgImAlexis 95f2945
add state-switch + tests and move restart js to vue
OmgImAlexis 5679ae1
replaced is_alive jsonp route with json
OmgImAlexis 7f64723
enable typescript validation in src directory
OmgImAlexis ebe146a
move config_general js to vue mounted
OmgImAlexis 10124a3
move manage_failedDownloads js to vue mounted
OmgImAlexis 92b25a0
move manage_subtitleMissed js to vue mounted
OmgImAlexis 8b7ef23
move mass-update js to vue mounted
OmgImAlexis a0b44f2
built themes
OmgImAlexis 79428ba
lint
OmgImAlexis 4fe630d
add missing quotes
OmgImAlexis c7d9544
Merge branch 'develop' into misc-changes
sharkykh e6eac8b
Merge branch 'develop' into misc-changes
sharkykh 95fa284
Update yarn.lock
sharkykh ff15877
Fix `manage.mako` white page
sharkykh 349f9b7
Merge branch 'develop' into misc-changes
sharkykh e396622
Replace `log.*` with `console.*`
sharkykh 15ff724
Remove extra `>` from `showheader.mako`
sharkykh 216e71d
Move `$.makeSubtitleRow` from JS to Vue
sharkykh 125e2dd
Move `$.makeEpisodeRow` from JS to Vue
sharkykh 81c3848
Remove empty `manage/init.js`
sharkykh e5606c0
Move the rest of `mass-update` JS to Vue
sharkykh 7265197
Remove empty `manage/index.js`
sharkykh d26099d
Remove empty `MEDUSA.manage` namespace
sharkykh ec08d23
Update tsconfig.json
sharkykh 6cf3444
Update `is_alive` content type header
sharkykh e927b4d
Merge branch 'develop' into misc-changes
sharkykh 2f090d7
Use restartState computed property
sharkykh 47eb879
Update changelog
sharkykh a759e9f
Update tests
sharkykh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
<template> | ||
<img v-bind="{ src, alt }" height="16" width="16" /> | ||
</template> | ||
<script> | ||
export default { | ||
name: 'state-switch', | ||
props: { | ||
/** | ||
* Theme for loading spinner | ||
*/ | ||
theme: { | ||
type: String, | ||
default: 'dark', | ||
validator: theme => [ | ||
'dark', | ||
'light' | ||
].includes(theme) | ||
}, | ||
/** | ||
* Loading, yes or no | ||
* null, true or false | ||
*/ | ||
state: { | ||
required: true, | ||
validator: state => [ | ||
'yes', | ||
'no', | ||
'loading', | ||
'true', | ||
'false', | ||
'null' | ||
].includes(String(state)) | ||
} | ||
}, | ||
computed: { | ||
src() { | ||
const { theme, realState: state } = this; | ||
return state === 'loading' ? `images/loading16-${theme}.gif` : `images/${state}16.png`; | ||
}, | ||
alt() { | ||
const { realState: state } = this; | ||
return state.charAt(0).toUpperCase() + state.substr(1); | ||
}, | ||
realState() { | ||
const { state } = this; | ||
if (['null', 'true', 'false'].includes(String(state))) { | ||
return { | ||
null: 'loading', | ||
true: 'yes', | ||
false: 'no' | ||
}[String(state)]; | ||
} | ||
return state; | ||
} | ||
} | ||
}; | ||
</script> | ||
<style> | ||
/* placeholder */ | ||
</style> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, maybe the cache control is needed right now since it's no longer a JSONP endpoint?
My point is the jQuery JSONP was sending the
_
argument (which I think was a timestamp), so the request was never cached. But now I think it's possible the response would be cached?I'm saying that just to be on the safe side.