Fix HDSpace pubdate parsing #5111
Conversation
So it will handle date times like: yesterday at 12:00:00
no need for log.exception here.
Cleanup the log.
calculate_date is not used anymore.
medusa/providers/generic_provider.py
Outdated
| return datetime.now(tz.tzlocal()) - timedelta(seconds=seconds) | ||
|
|
||
| if fromtimestamp: | ||
| dt = datetime.fromtimestamp(int(pubdate), tz=tz.gettz('UTC')) | ||
| else: | ||
| dt = parser.parse(pubdate, dayfirst=df, yearfirst=yf, fuzzy=True) | ||
| from tzlocal import get_localzone |
There was a problem hiding this comment.
Forgot to remove the import?
There was a problem hiding this comment.
@p0psicles You marked as resolved but the import is still there
Edit: Marked as unresolved
| @@ -574,12 +574,25 @@ def parse_pubdate(pubdate, human_time=False, timezone=None, **kwargs): | |||
| matched_time = int(round(float(matched_time.strip()))) | |||
|
|
|||
| seconds = parse('{0} {1}'.format(matched_time, matched_granularity)) | |||
| if seconds is None: | |||
| log.warning('Failed parsing human time: {0} {1}', matched_time, matched_granularity) | |||
There was a problem hiding this comment.
I don't think the warning is needed since it's already going to cause an exception.
There was a problem hiding this comment.
Yeah but up until now we often had to guess why
There was a problem hiding this comment.
Yes but now the exception includes the details you added to the warning log, so you don't really need the log?
There was a problem hiding this comment.
The exeception details are not logged down the stack.
There was a problem hiding this comment.
Oh, I see now. Sorry I missed that.
| 'expected': datetime.now().replace(microsecond=0, tzinfo=tz.gettz('UTC')) - timedelta(days=1, minutes=10, seconds=25), | ||
| 'human_time': False | ||
| }, | ||
| { # p22: hd-space test human date like today at 12:00:00 |
| @@ -127,6 +127,16 @@ | |||
| 'timezone': 'US/Eastern', | |||
| 'fromtimestamp': True | |||
| }, | |||
| { # p22: hd-space test human date like yesterdat at 12:00:00 | |||
|
Just waiting for supers test/go |
sharkykh
added
Needs testing
fix #5100
@duramato