Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/apiv2 add config search attributes #5079

Merged
merged 5 commits into from
Oct 9, 2018
Merged

Feature/apiv2 add config search attributes #5079

merged 5 commits into from
Oct 9, 2018

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Aug 29, 2018 •
edited
Loading

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

TODO:

  • update api-description.yml
  • CHANGELOG.md

@p0psicles p0psicles changed the base branch from master to develop August 29, 2018 08:28
@p0psicles
Copy link
Contributor Author

@OmgImAlexis should be good2go

@p0psicles
Copy link
Contributor Author

@medariox?

@medariox medariox merged commit 54935ae into develop Oct 9, 2018
@medariox medariox deleted the feature/apiv2-add-config-search-attributes branch October 9, 2018 16:08
@sharkykh sharkykh added this to the 0.2.11 milestone Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medariox medariox medariox approved these changes

Assignees

@OmgImAlexis OmgImAlexis

Labels
Changelog Requires a changelog entry Concluded Enhancement
Projects
None yet
Milestone
0.2.11
Development

Successfully merging this pull request may close these issues.
4 participants
@p0psicles @medariox @OmgImAlexis @sharkykh