Feature/fully vueify notifications #4913

p0psicles · 2018-08-18T14:53:05Z

PR is based on the DEVELOP branch
Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
Read the contribution guide

TODO:

* Merge develop.

…lly-vueify-notifications # Conflicts: # themes-default/slim/views/layouts/main.mako # themes/dark/assets/js/app.js # themes/dark/assets/js/index.js # themes/dark/assets/js/vendors.js # themes/light/assets/js/app.js # themes/light/assets/js/index.js # themes/light/assets/js/vendors.js # themes/light/templates/layouts/main.mako

Make it available for usage from mako files. * Rename Config-checkbox to config-toggle-slider. * Rebuild themes.

…thing else.

p0psicles · 2018-08-22T10:55:09Z

@OmgImAlexis can you check the overal setup now? As next i'll add all the notifiers to apiv2 and the page. As that's allot of work, i'd like to limit the refactoring to as little as possible.

…lly-vueify-notifications # Conflicts: # themes-default/slim/src/index.js # themes/dark/assets/js/index.js # themes/dark/assets/js/vendors.js # themes/light/assets/js/index.js # themes/light/assets/js/vendors.js

sharkykh · 2018-08-28T23:09:55Z

@p0psicles Move it to 0.2.10?

p0psicles · 2018-08-29T05:40:29Z

If current notifications page is acceptable. But think thats in master already anyway.
Not sure, havent run master in long time

sharkykh · 2018-08-29T13:21:25Z

If current notifications page is acceptable. But think thats in master already anyway.
Not sure, havent run master in long time

Have you found a bug in the current notifications page?

OmgImAlexis · 2018-10-27T12:21:47Z

themes-default/slim/views/config_notifications.mako

                                            </label>
+                                            <div class="col-sm-10 content">
+                                                <input type="text" name="plex_server_token" id="plex_server_token" v-model="notifiers.plex.server.token" @change="save()" @update="notifiers.plex.server.token = $event" class="form-control input-sm max-input350"/>
+                                                <!-- Can't use the config-textbox component, because of the complex descriptions -->


This can be fixed by using a slot in the config-textbox try this or something similar.

diff --git a/themes-default/slim/src/components/config-textbox.vue b/themes-default/slim/src/components/config-textbox.vue index cceb95db3..dd7bd569b 100644 --- a/themes-default/slim/src/components/config-textbox.vue +++ b/themes-default/slim/src/components/config-textbox.vue @@ -5,10 +5,10 @@ <label :for="id" class="col-sm-2 control-label"> <span>{{ label }}</span> </label> - <div class="col-sm-10 content"> + <slot class="col-sm-10 content"> <input :type="type" v-bind="{id, name: id}" v-model="localValue" :class="inputClass" :placeholder="placeholder"/> <p v-for="(explanation, index) in explanations" :key="index">{{ explanation }}</p> - </div> + </slot> </div> </div> </div>

Created a new component </> which is really bare. And just sets up the divs and styling. This makes use of slots.

This component can be used to create a standard bootstrapped label/content form-group. <slot> can be used to parse your own content.

Use v-model in stead of :value. Added <slot></slot>.

* Utilized the new config-template component. * Utilized config-textbox slots.

…lly-vueify-notifications # Conflicts: # themes-default/slim/src/components/index.js # themes/dark/assets/js/medusa-runtime.js # themes/light/assets/js/medusa-runtime.js

ghost · 2018-10-28T18:42:25Z

DeepCode analyzed this pull request.
There is 1 new info report.

Click to see more details.

Moved config-template.vue component to helpers.

OmgImAlexis · 2018-10-28T21:04:33Z

themes-default/slim/src/components/helpers/config-textbox.vue

@@ -1,13 +1,14 @@
 <template>
-    <div id="config-textbox-content">
+    <div id="config-textbox">


Keep in mind if this is used more than once on the page you'll have two items with the same ID. I'd go with classes instead.

OmgImAlexis · 2018-10-28T21:06:03Z

themes-default/slim/src/components/helpers/select-list.vue

@@ -92,15 +92,18 @@ export default {
            this.indexCounter += 1;
        },
        addNewItem() {
+            const { newItem, editItems } = this;
            if (this.newItem === '') {


When comparing use the const value, not this.

little bit down i'm assiging to newItem:
this.newItem = '';
Should I still use the const?

This this is also correct?:

deleteItem(item) { const { editItems } = this; this.editItems = editItems.filter(e => e !== item); this.$refs.newItemInput.focus(); this.$emit('change', editItems); },

I could go even further and destructure also $refs and $emit?

So this would be "correct":

deleteItem(item) { const { $refs, $emit, editItems } = this; this.editItems = editItems.filter(e => e !== item); $refs.newItemInput.focus(); $emit('change', editItems); },

OmgImAlexis · 2018-10-28T21:07:29Z

themes-default/slim/src/components/helpers/show-selector.vue

+        placeholder: String,
+        selectClass: {
+            type: String,
+            default: 'select-show form-control input-sm-custom'


Should selectClass only be select-show?

Sorry don't understand the question

Since this will replace the classes won't form-control and input-sm-custom be needed to keep it looking like a form? I would have though just select-show needs to be replaced.

This just allows it to be customized. Maybe you don't want to use the bootstrap classes at all. In my case, i'm using show-selector in config-notifications. And there I don't want the select-show class, which is mainly used for the switching shows component. And style it for different viewports.

Signed-off-by: Alexis Tyler <[email protected]>

* Fixed lint-css * fixed xo

OmgImAlexis

Frontend looks good to me.

p0psicles · 2018-10-29T17:05:27Z

@medariox okay?

…lly-vueify-notifications # Conflicts: # themes/dark/assets/js/index.js.map # themes/dark/assets/js/vendors.js.map # themes/light/assets/js/index.js.map # themes/light/assets/js/vendors.js.map

p0psicles added 4 commits August 4, 2018 23:32

Started vueifying config_notifications.mako

9f6859f

* Merge develop.

Added ConfigToggleSlider to index.js.

6ae2f6a

Make it available for usage from mako files. * Rename Config-checkbox to config-toggle-slider. * Rebuild themes.

Reverted some indents.

1081768

p0psicles added Bug In progress labels Aug 18, 2018

p0psicles added this to the 0.2.9 milestone Aug 18, 2018

Sync themes.

c2e7bfb

OmgImAlexis self-requested a review August 19, 2018 05:24

p0psicles added 6 commits August 19, 2018 13:10

Add kodi.password to apiv2.

ac9280c

Added config-textbox component to index.js.

bba1d01

Updated store with missing attributes.

78f8dd7

Use config-toggle-slider for kodi checkboxes.

f54cf0a

Add plex server section.

154f9e4

Added plex home theater.

fbed61e

p0psicles mentioned this pull request Aug 20, 2018

add new config values #4635

Closed

OmgImAlexis mentioned this pull request Aug 21, 2018

Vueify #4058

Open

p0psicles self-assigned this Aug 21, 2018

p0psicles added 2 commits August 22, 2018 11:32

Move notifications to data_section.

1a66e10

Added store notifiers.js, as notifications.js is already used by some…

08b01f4

…thing else.

p0psicles added 2 commits August 22, 2018 12:57

Merge remote-tracking branch 'remotes/origin/develop' into feature/fu…

477a2e4

…lly-vueify-notifications # Conflicts: # themes-default/slim/src/index.js # themes/dark/assets/js/index.js # themes/dark/assets/js/vendors.js # themes/light/assets/js/index.js # themes/light/assets/js/vendors.js

Webpack Build, xo and gulp sync.

28aaa95

sharkykh added the Changelog Requires a changelog entry label Aug 23, 2018

Merge branch 'develop' into feature/fully-vueify-notifications

39ebda0

OmgImAlexis modified the milestones: 0.2.9, 0.2.10 Aug 29, 2018

OmgImAlexis reviewed Oct 27, 2018

View reviewed changes

p0psicles added 6 commits October 28, 2018 19:26

Added a new component config-template.vue

ac906f3

This component can be used to create a standard bootstrapped label/content form-group. <slot> can be used to parse your own content.

Optimize the usage of v-bind.

def435b

Use v-model in stead of :value. Added <slot></slot>.

Renamed selectedShowList to selectedShowSlug.

6ed3c74

Removed the jquery on click handlers.

0016d5c

* Utilized the new config-template component. * Utilized config-textbox slots.

Added (fixed) snotify.

1f8adc3

Merge remote-tracking branch 'remotes/origin/develop' into feature/fu…

9cc67c1

…lly-vueify-notifications # Conflicts: # themes-default/slim/src/components/index.js # themes/dark/assets/js/medusa-runtime.js # themes/light/assets/js/medusa-runtime.js

Build themes.

3fa238d

Moved config-template.vue component to helpers.

OmgImAlexis reviewed Oct 28, 2018

View reviewed changes

OmgImAlexis and others added 4 commits October 29, 2018 07:46

split notifiers into dir

b6c3e4b

Signed-off-by: Alexis Tyler <[email protected]>

Recreated snapshots for config-textbox* components.

2bef98f

Merge branch 'develop' into feature/fully-vueify-notifications

079bac2

Destructured object variables for components, where needed.

869c190

* Fixed lint-css * fixed xo

p0psicles added Concluded Frontend Backend and removed In progress labels Oct 29, 2018

OmgImAlexis previously approved these changes Oct 29, 2018

View reviewed changes

Merge remote-tracking branch 'remotes/origin/develop' into feature/fu…

8b10bb7

…lly-vueify-notifications # Conflicts: # themes/dark/assets/js/index.js.map # themes/dark/assets/js/vendors.js.map # themes/light/assets/js/index.js.map # themes/light/assets/js/vendors.js.map

p0psicles dismissed OmgImAlexis’s stale review via 8b10bb7 October 29, 2018 20:46

medariox approved these changes Oct 29, 2018

View reviewed changes

medariox changed the title ~~[WIP] Feature/fully vueify notifications~~ Feature/fully vueify notifications Oct 29, 2018

medariox merged commit 98aeff7 into develop Oct 29, 2018

CerebralXor mentioned this pull request Oct 31, 2018

New feature: Allow use of Pushover priorities. #5567

Merged

3 tasks

sharkykh deleted the feature/fully-vueify-notifications branch November 4, 2018 17:07

p0psicles mentioned this pull request Nov 13, 2018

Fix add-show-options toggle buttons. #5709

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/fully vueify notifications #4913

Feature/fully vueify notifications #4913

p0psicles commented Aug 18, 2018 •

edited

Loading

p0psicles commented Aug 22, 2018

sharkykh commented Aug 28, 2018

p0psicles commented Aug 29, 2018

sharkykh commented Aug 29, 2018

OmgImAlexis Oct 27, 2018

p0psicles Oct 28, 2018

ghost commented Oct 28, 2018

OmgImAlexis Oct 28, 2018 •

edited

Loading

p0psicles Oct 29, 2018

OmgImAlexis Oct 28, 2018

p0psicles Oct 29, 2018

p0psicles Oct 29, 2018

p0psicles Oct 29, 2018

p0psicles Oct 29, 2018

OmgImAlexis Oct 28, 2018

p0psicles Oct 29, 2018

OmgImAlexis Oct 29, 2018

p0psicles Oct 29, 2018 •

edited

Loading

OmgImAlexis left a comment

p0psicles commented Oct 29, 2018

Feature/fully vueify notifications #4913

Feature/fully vueify notifications #4913

Conversation

p0psicles commented Aug 18, 2018 • edited Loading

TODO:

p0psicles commented Aug 22, 2018

sharkykh commented Aug 28, 2018

p0psicles commented Aug 29, 2018

sharkykh commented Aug 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Oct 28, 2018

OmgImAlexis Oct 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

p0psicles Oct 29, 2018 • edited Loading

Choose a reason for hiding this comment

OmgImAlexis left a comment

Choose a reason for hiding this comment

p0psicles commented Oct 29, 2018

p0psicles commented Aug 18, 2018 •

edited

Loading

OmgImAlexis Oct 28, 2018 •

edited

Loading

p0psicles Oct 29, 2018 •

edited

Loading