Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix norbits provider formatting download url incorrectly. #4642

Merged
merged 4 commits into from
Jul 10, 2018
Merged

Fix norbits provider formatting download url incorrectly. #4642

merged 4 commits into from
Jul 10, 2018

Conversation

Hammering
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

urljoin removes '?' in end of "download.php?" making the download links be "download.phpid=" instead of "download.php?id="

medariox
medariox approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medariox medariox merged commit fce92f6 into pymedusa:develop Jul 10, 2018
@Hammering Hammering deleted the bugfix/norbits-url branch July 10, 2018 14:25
@sharkykh sharkykh added this to the 0.2.7 milestone Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medariox medariox medariox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Hammering @medariox @sharkykh