Fix show-selector not honoring option to split shows & anime #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
OmgImAlexis
reviewed
Jul 7, 2018
| const lists = [ | ||
| { type: 'Shows', shows: [] }, | ||
| { type: 'Anime', shows: [] } | ||
| ]; | ||
|
|
||
| shows.forEach(show => { | ||
| const type = show.config.anime === true ? 1 : 0; | ||
| const type = animeSplitHome && show.config.anime ? 1 : 0; |
There was a problem hiding this comment.
Change this to Number(animeSplitHome && show.config.anime) as it'll return 1/0 depending on the boolean passed.
There was a problem hiding this comment.
I actually did that on my first draft of this code, but I feared it wasn't clear enough.
Edit: Updated code.
OmgImAlexis
previously approved these changes
Jul 7, 2018
OmgImAlexis
previously approved these changes
Jul 9, 2018
Unused since converting show-selector to Vue.
sharkykh
force-pushed
the
bugfix/show-selector
branch
from
13c3595 to
7b07551
Compare
|
Python code LGTM, JS should be fine too? @OmgImAlexis ? |
OmgImAlexis
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show-selectornot honoringapp.ANIME_SPLIT_HOME.show-selectorto Vue.