-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vueify Root Dirs #4059
Merged
+901
−978
Merged
Vueify Root Dirs #4059
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
205a425
Add Root Dirs Vue component
sharkykh c6fd90c
Update "Add New Show"
sharkykh ed4e14c
Update "Add Existing Show" and `api/v2/internal/existingSeries`
sharkykh fe83d14
Update "Add Recommended Shows"
sharkykh 0c1c1e1
Update "Config - General"
sharkykh 21d4d4e
root-dirs to rootDirs
sharkykh fcdf553
Fix abbreviations and double quotes
sharkykh c616417
Fix bug when editing a root dir path to a sub-dir (race condition)
sharkykh 93c17bb
Add bind attributes and native events to the main select element
sharkykh bd38f76
Merge branch 'develop' into feature/vue-root-dirs
sharkykh 63d7c9d
Merge branch 'develop' into feature/vue-root-dirs
sharkykh 30381bc
Simplify internal resource code
sharkykh 29acae5
Fix bug when removing the last root-dir
sharkykh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a biggie, but I think this can go just after line 66? One
if
less 🎉The rest of the python code LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks like it to me too. Good catch! Thanks.
I will fix it as soon as I can.