Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move js to viewlogs page #4031

Merged
merged 2 commits into from
Apr 16, 2018
Merged

move js to viewlogs page #4031

merged 2 commits into from
Apr 16, 2018

Conversation

OmgImAlexis
Copy link
Collaborator

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@OmgImAlexis OmgImAlexis force-pushed the feature/move-js-to-viewlogs branch from 4921e1b to 5df9b97 Compare April 16, 2018 03:47
@OmgImAlexis OmgImAlexis changed the title remove js to viewlogs page move js to viewlogs page Apr 16, 2018
@codecov-io
Copy link

codecov-io commented Apr 16, 2018

Codecov Report

Merging #4031 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4031   +/-   ##
========================================
  Coverage    29.37%   29.37%           
========================================
  Files          277      277           
  Lines        35495    35495           
========================================
  Hits         10428    10428           
  Misses       25067    25067

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66bcbb3...2ebbc33. Read the comment docs.

medariox
medariox previously approved these changes Apr 16, 2018
@medariox medariox merged commit b1ae279 into develop Apr 16, 2018
@medariox medariox deleted the feature/move-js-to-viewlogs branch April 16, 2018 09:25
@p0psicles p0psicles added this to the 0.2.2 milestone Apr 21, 2018
@OmgImAlexis OmgImAlexis mentioned this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants