Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when trying to save default show settings. Fixes #4002 #4027

Merged
merged 2 commits into from
Apr 18, 2018

Conversation

medariox
Copy link
Contributor

@medariox medariox commented Apr 15, 2018

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

There is still a bug I'd like to fix: saving new Default Settings without changing the quality preset causes the qualities to fall back to a different custom quality. Will be fixed in: #3818

@codecov-io
Copy link

codecov-io commented Apr 15, 2018

Codecov Report

Merging #4027 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4027   +/-   ##
========================================
  Coverage    29.38%   29.38%           
========================================
  Files          277      277           
  Lines        35492    35492           
========================================
  Hits         10428    10428           
  Misses       25064    25064

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f563fa...7c11ec3. Read the comment docs.

@fernandog
Copy link
Contributor

@medariox does it fix when show only have allowed quality and the preferred quality wrongly sets SDTV in preferred?

@sharkykh
Copy link
Contributor

sharkykh commented Apr 16, 2018

@fernandog No, but it's already fixed and working in #3818 (for add show and edit show)

@OmgImAlexis OmgImAlexis requested a review from p0psicles April 18, 2018 00:24
@OmgImAlexis OmgImAlexis merged commit ae0d40c into develop Apr 18, 2018
@medariox medariox deleted the feature/fix-show-default-save branch April 18, 2018 09:11
@p0psicles p0psicles added this to the 0.2.2 milestone Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants