Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history view elements #11653

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Fix history view elements #11653

merged 1 commit into from
Mar 17, 2024

Conversation

medariox
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@medariox medariox added this to the 1.0.20 milestone Mar 17, 2024
@medariox medariox merged commit 1b0a21c into develop Mar 17, 2024
9 of 11 checks passed
@medariox medariox deleted the fix-history branch March 17, 2024 16:38
@XxUnkn0wnxX
Copy link

XxUnkn0wnxX commented Mar 17, 2024

@medariox History is still uber dead:

2024-03-18 03:42:11 ERROR    TORNADO :: [1b0a21c] Uncaught exception in APIv2: AttributeError("'list' object has no attribute 'get'")
Request: GET /api/v2/history?page=1&limit=50&sort=[%7B%22field%22:%22actionDate%22,%22type%22:%22desc%22%7D] (127.0.0.1)
Traceback (most recent call last):
  File "/Users/Admin/Apps/Medusa/ext/tornado/web.py", line 1704, in _execute
    result = await result
             ^^^^^^^^^^^^
  File "/Users/Admin/Apps/Medusa/ext/tornado/gen.py", line 769, in run
    yielded = self.gen.throw(*exc_info)  # type: ignore
              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/Admin/Apps/Medusa/medusa/server/api/v2/base.py", line 64, in async_call
    content = yield IOLoop.current().run_in_executor(executor, prepared)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/Admin/Apps/Medusa/ext/tornado/gen.py", line 762, in run
    value = future.result()
            ^^^^^^^^^^^^^^^
  File "/usr/local/Cellar/[email protected]/3.11.6_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/Admin/Apps/Medusa/medusa/server/api/v2/history.py", line 139, in get
    field = sort[0].get('field').lower()
            ^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'get'

the page view is empty now on the history page, last working commit: 70f9e90

Issue related to this pull: #11654 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants