Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More rebranding #1162

Merged
merged 11 commits into from
Sep 21, 2016
Merged

More rebranding #1162

merged 11 commits into from
Sep 21, 2016

Conversation

ratoaq2
Copy link
Contributor

@ratoaq2 ratoaq2 commented Sep 21, 2016 •
edited
Loading

THIS PR SHOULD BE SQUASHED

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read contribution guide
  • Trying to get rid of old names as much as possible and organize all fixed values (urls, database names, log names) in init.py
  • Handling startup scripts

@ratoaq2 ratoaq2 added this to the 0.1.6 milestone Sep 21, 2016
OmgImAlexis
OmgImAlexis suggested changes Sep 21, 2016
View reviewed changes
Copy link
Collaborator

@OmgImAlexis OmgImAlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the API changes can be made since APIv1 is meant to be backwards compatible. Everything in that should be left with old Sickbeard/rage stuff still in it including the names, etc.

@ratoaq2
Copy link
Contributor Author

ratoaq2 commented Sep 21, 2016

I have changed only name of internal methods... The json in/out is still the same with same property names

@fernandog fernandog force-pushed the feature/more-rebranding branch 4 times, most recently from 2e2caa7 to bf63256 Compare September 21, 2016 14:32
@fernandog
Copy link
Contributor

@xo you must approve the review

@ratoaq2 ratoaq2 force-pushed the feature/more-rebranding branch from bf63256 to 310dcce Compare September 21, 2016 20:33
@ratoaq2 ratoaq2 self-assigned this Sep 21, 2016
@fernandog
Copy link
Contributor

tested and everything looks ok! nice job!

@OmgImAlexis OmgImAlexis merged commit e8bcda6 into develop Sep 21, 2016
@fernandog fernandog deleted the feature/more-rebranding branch September 21, 2016 23:43
@fernandog fernandog removed the Needs testing Requires testing to make sure it's working as intended label Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmgImAlexis OmgImAlexis OmgImAlexis approved these changes

@fernandog fernandog fernandog approved these changes

Assignees

@ratoaq2 ratoaq2

Labels
Concluded Enhancement
Projects
None yet
Milestone
0.1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@ratoaq2 @fernandog @OmgImAlexis