Release/release 1.0.11 #11099
Merged
Release/release 1.0.11 #11099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
medariox
commented
Jan 14, 2023
medariox
commented
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
Sync master & develop
* Add a tooltip.
* Fix parsing for shows that have year in the title Specific show 1923. Added conditions to the rule wrongfully parse year in a multi part release string. * Add more guessit tests to verify the title * Fix guessit tests. Needed year and alias. * Fix typo * Fix test * Remove bad test since GuessIt parsing incorrectly guessit 1923.2022.S01E01.720p.WEB.h264-Group.mkv -t episode The above does not parse the title correctly. * Fix guessit parsing for show titles that exist of only numbers. * and where the title is parsed as the year. * added tests to test_guessit.yml * Removed this, as it's not doing anything. * W293 blank line contains whitespace Co-authored-by: Thomas Patry <Thomas [email protected]> Co-authored-by: p0psicles <[email protected]> Co-authored-by: Dario <[email protected]>
p0psicles
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.