Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authenticate websocket connections #10914

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Authenticate websocket connections #10914

merged 3 commits into from
Sep 5, 2022

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Sep 5, 2022 •
edited
Loading

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@stealthcopter

@p0psicles p0psicles added this to the 1.0.8 milestone Sep 5, 2022
stealthcopter
stealthcopter approved these changes Sep 5, 2022
View reviewed changes
Copy link

@stealthcopter stealthcopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that unauthenticated connections are no longer permitted 👍

@p0psicles p0psicles merged commit 782361e into develop Sep 5, 2022
@p0psicles p0psicles deleted the feature/fix-ws-sec-vul branch September 5, 2022 19:45
PaulLiang1 pushed a commit to PaulLiang1/Medusa that referenced this pull request Oct 10, 2022
@p0psicles @PaulLiang1
Authenticate websocket connections (pymedusa#10914)
321e56f 
* Authenticate websocket connections

* fix flake issues.

* flake2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stealthcopter stealthcopter stealthcopter approved these changes

Assignees
No one assigned
Labels
Bug Concluded Security
Projects
None yet
Milestone
1.0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@p0psicles @stealthcopter