Feature/UI indicate when no connection #10774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Have it reload the page instead of routing to home.
* Extend the retries for the socket connection to 25 x 2500 ms.
reconman
reviewed
Jun 29, 2022
| @@ -9,7 +9,11 @@ | |||
| <span class="icon-bar" /> | |||
| <span class="icon-bar" /> | |||
| </button> | |||
| <app-link class="navbar-brand" href="home/" title="Medusa"><img alt="Medusa" src="images/medusa.png" style="height: 50px;" class="img-responsive pull-left"></app-link> | |||
| <app-link v-if="isConnected || !socketIsConnected" class="navbar-brand" style="position: relative" title="Medusa"> | |||
There was a problem hiding this comment.
Isn't this supposed to be !isConnected?
Right now I always get a disconnected icon and so clicking on the logo refreshes the page.
There was a problem hiding this comment.
I fixed that in a PR that came after
There was a problem hiding this comment.
Was broken on my end. Had the fixed version, but my Synology Reverse Proxy didn't forward it correctly without some additional config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a small indicator (red cross) to the Medusa log in the top left, for when medusa has no connection to the apiv2 or the websocket.
Modified the behavior of the icon, in that when a connection is lost, clicking on it will reload the whole page. Instead of routing to
/#Implement #10761