Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always overwrite app.BRANCH when we have a commit_branch_env. #10523

Merged
merged 1 commit into from
Apr 22, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions medusa/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -523,10 +523,8 @@ def initialize(self, console_logging=True):

if commit_branch_env and app.CUR_COMMIT_BRANCH != commit_branch_env:
app.CUR_COMMIT_BRANCH = commit_branch_env

if not app.BRANCH and app.CUR_COMMIT_BRANCH:
# Overwrite the current branch for non-git installations like docker.
app.BRANCH = app.CUR_COMMIT_BRANCH
app.BRANCH = commit_branch_env

# Asume we only have these environ variables when building a docker container.
app.RUNS_IN_DOCKER = os.environ.get('MEDUSA_COMMIT_HASH') and os.environ.get('MEDUSA_COMMIT_BRANCH')
Expand Down