Optimize docker build pipeline #10518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconman
force-pushed
the
optimize-docker-builds
branch
from
421ee23 to
2e99ef1
Compare
|
Proof of it working: |
|
Does it also successfully build all architectures? |
|
Yes, see https://github.com/reconman/Medusa/pkgs/container/medusa, tab OS / Arch. I mostly copy-pasted what I had in another repo where I've been using a similar pipeline for half a year now. |
|
Nice. I'll look more into it tomorrow. |
|
@reconman it should also show the branch in docker containers now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced some manual actions with predefined Github actions and combined both workflow files.
I've tested the changes in the master and develop branches of my fork, although I modified it a bit so I'm pushing to the Github docker registry instead of Dockerhub.