Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify PUID and PGID default values for Docker #10517

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Simplify PUID and PGID default values for Docker #10517

merged 1 commit into from
Apr 20, 2022

Conversation

reconman
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@reconman reconman changed the base branch from master to develop April 20, 2022 17:07
@p0psicles p0psicles closed this Apr 20, 2022
@p0psicles p0psicles reopened this Apr 20, 2022
@p0psicles
Copy link
Contributor

I noticed when running develop the git branch and git commit are not coming through. Could you take a look at that?

@reconman
Copy link
Contributor Author

@p0psicles I already created an issue for that almost 1 year ago. It was already broken back then. #9532

@reconman
Copy link
Contributor Author

Oh wait, it seems your build script doesn't set the environment variables right now.

@p0psicles p0psicles merged commit b5b4167 into pymedusa:develop Apr 20, 2022
@reconman reconman deleted the non-root-docker branch April 22, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reconman @p0psicles