Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLflow autologging #921
MLflow autologging #921
Changes from 8 commits
a659829
244a526
8f07861
a2664c1
5ee13a6
53f2dd8
d224b5f
42eac0f
03b735a
5aa1138
937f407
12754be
9e4f28c
307e668
2fb0caf
bf00eb2
065edf6
dd6562c
5548c7b
2d2469e
d5d7311
4a3be31
2901248
39b9f9e
e9dd262
3aa6c8f
8003ddf
df13f6e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we raise here something more informative so that this does not pass quietly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a test for the behavior. If the import doesn't work then it won't be logged via MLflow.
Should it be silent? I don't think it should raise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if the import fails and the user actively wants to logs and something fails then we should at least get a warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a logging info level. That feel sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we try working with a lighter version : https://pypi.org/project/mlflow-skinny/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for the test dependencies which tests with SQL connection as well. If the import doesn't work then I have an error with suggestion to install. It is not a dependency of the package