Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruff E501 ignore #619

Merged
merged 11 commits into from
Apr 12, 2024
Merged

Remove ruff E501 ignore #619

merged 11 commits into from
Apr 12, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Apr 8, 2024

Make the line length bounded. The main change is

image

** The rest is just cleaning docstrings and a notebook with minor style formatting. **


📚 Documentation preview 📚: https://pymc-marketing--619.org.readthedocs.build/en/619/

@juanitorduz juanitorduz marked this pull request as draft April 8, 2024 18:52
@juanitorduz juanitorduz self-assigned this Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.61%. Comparing base (ff937f4) to head (cdff191).

Files Patch % Lines
pymc_marketing/model_builder.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
- Coverage   91.64%   91.61%   -0.03%     
==========================================
  Files          22       22              
  Lines        2273     2277       +4     
==========================================
+ Hits         2083     2086       +3     
- Misses        190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz marked this pull request as ready for review April 11, 2024 12:00
@juanitorduz juanitorduz requested review from wd60622 and twiecki April 11, 2024 12:00
@juanitorduz juanitorduz merged commit e2dba27 into main Apr 12, 2024
9 of 10 checks passed
@juanitorduz juanitorduz deleted the fix_E501 branch April 12, 2024 08:47
twiecki pushed a commit that referenced this pull request Sep 10, 2024
remove ruff E501 ignore
twiecki pushed a commit that referenced this pull request Sep 10, 2024
remove ruff E501 ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants