-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use union of default and user provided configs in ModelBuilder #565
Use union of default and user provided configs in ModelBuilder #565
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
It makes a lot of sense 😅 . There are some test failing though .... |
e0b7c0d
to
6c2dfb4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 21 21
Lines 1999 1999
=======================================
Hits 1820 1820
Misses 179 179 ☔ View full report in Codecov by Sentry. |
@juanitorduz tests are passing |
Ups!you are right! I don't know which CI I was looking then 🙈 |
You didn't imagine it. I had to fix a test |
Haha ok! Now everything makes sense 😄 |
Description
I don't see a good reason not to do this for the users?
Related Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--565.org.readthedocs.build/en/565/