Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use union of default and user provided configs in ModelBuilder #565

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

ricardoV94
Copy link
Contributor

@ricardoV94 ricardoV94 commented Mar 1, 2024

Description

I don't see a good reason not to do this for the users?

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--565.org.readthedocs.build/en/565/

@ricardoV94 ricardoV94 added enhancement New feature or request ModelBuilder Related to the ModelBuilder class and its children labels Mar 1, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ricardoV94 ricardoV94 mentioned this pull request Mar 1, 2024
13 tasks
@juanitorduz
Copy link
Collaborator

It makes a lot of sense 😅 . There are some test failing though ....

@ricardoV94 ricardoV94 force-pushed the model_sampler_config_union branch from e0b7c0d to 6c2dfb4 Compare March 4, 2024 11:19
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (4702408) to head (6c2dfb4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files          21       21           
  Lines        1999     1999           
=======================================
  Hits         1820     1820           
  Misses        179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricardoV94
Copy link
Contributor Author

@juanitorduz tests are passing

@juanitorduz
Copy link
Collaborator

Ups!you are right! I don't know which CI I was looking then 🙈

@ricardoV94 ricardoV94 merged commit cb5dba2 into pymc-labs:main Mar 4, 2024
9 checks passed
@ricardoV94
Copy link
Contributor Author

Ups!you are right! I don't know which CI I was looking then 🙈

You didn't imagine it. I had to fix a test

@juanitorduz
Copy link
Collaborator

Haha ok! Now everything makes sense 😄

@ricardoV94 ricardoV94 added maintenance and removed enhancement New feature or request labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance ModelBuilder Related to the ModelBuilder class and its children
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants