Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml #536

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Update ci.yml #536

merged 2 commits into from
Feb 20, 2024

Conversation

ricardoV94
Copy link
Contributor

@ricardoV94 ricardoV94 commented Feb 20, 2024

Should have be done together with #535

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--536.org.readthedocs.build/en/536/

Should have be done together with #535
@ricardoV94
Copy link
Contributor Author

It's a bit strange the CI tests aren't running at all (nor where they in #535 ?)

@ricardoV94
Copy link
Contributor Author

Okay it was a forgotten parenthesis

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a27187) 91.36% compared to head (bbee631) 91.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files          21       21           
  Lines        2073     2073           
=======================================
  Hits         1894     1894           
  Misses        179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄!

@ricardoV94 ricardoV94 merged commit d3344cf into main Feb 20, 2024
9 checks passed
@ricardoV94
Copy link
Contributor Author

Oops should have squashed. Anyway it's fixed

@ricardoV94 ricardoV94 deleted the ricardoV94-patch-2 branch February 20, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants