Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved mypy error in base.py #1285

Merged
merged 1 commit into from
Dec 16, 2024
Merged

solved mypy error in base.py #1285

merged 1 commit into from
Dec 16, 2024

Conversation

nataziel
Copy link
Contributor

@nataziel nataziel commented Dec 16, 2024

solved mypy error in base.py

Description

_add_hdi_to_plot expects alpha input param to be of type float. Pylance reports that it is the correct type but mypy does not. Added dtype=float to preceeding np.linspace call and now mypy no longer reports that error.

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1285.org.readthedocs.build/en/1285/

@github-actions github-actions bot added the MMM label Dec 16, 2024
@wd60622
Copy link
Contributor

wd60622 commented Dec 16, 2024

Thank you @nataziel! Running cicd now

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (95db52b) to head (2b3712f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1285   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files          42       42           
  Lines        4456     4456           
=======================================
  Hits         4236     4236           
  Misses        220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nataziel !

@wd60622 wd60622 merged commit 3aeb56e into pymc-labs:main Dec 16, 2024
21 checks passed
aseyboldt pushed a commit to aseyboldt/pymc-marketing that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants