Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tvp scaling in contribution grid #1253

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Dec 3, 2024

Description

Multiply out using xarray broadcasting

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1253.org.readthedocs.build/en/1253/

@wd60622 wd60622 linked an issue Dec 3, 2024 that may be closed by this pull request
@github-actions github-actions bot added the MMM label Dec 3, 2024
@wd60622 wd60622 requested a review from juanitorduz December 3, 2024 09:30
@github-actions github-actions bot added TVPs Related to time varying parameters bug Something isn't working enhancement New feature or request labels Dec 3, 2024
@wd60622
Copy link
Contributor Author

wd60622 commented Dec 3, 2024

Working on test right now. Thinking about what is the best way to check this... open to suggestions

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (1d89f66) to head (ded485d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1253   +/-   ##
=======================================
  Coverage   95.64%   95.65%           
=======================================
  Files          39       39           
  Lines        4091     4096    +5     
=======================================
+ Hits         3913     3918    +5     
  Misses        178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the tests label Dec 3, 2024
@juanitorduz juanitorduz merged commit addc996 into main Dec 3, 2024
13 checks passed
@juanitorduz juanitorduz deleted the 819-time-varying-media-not-considered-in-channel_contributions_forward_pass branch December 3, 2024 11:05
@juanitorduz juanitorduz added this to the 0.11.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request MMM tests TVPs Related to time varying parameters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time Varying Media not considered in channel_contributions_forward_pass
2 participants