-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock posterior with prior on various CLV tests #1156
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 39 39
Lines 4063 4063
=======================================
Hits 3885 3885
Misses 178 178 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Thanks for speeding up the tests! Couldn't get around to reviewing this today, but these new test methods may be useful for my ongoing plotting PR. |
I've mocked the posterior sampling with the sample_prior_predictive for handful of the CLV tests that only check for input and output.
For instance, save and load. Should shave off some time in the CI
📚 Documentation preview 📚: https://pymc-marketing--1156.org.readthedocs.build/en/1156/