Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock posterior with prior on various CLV tests #1156

Merged
merged 8 commits into from
Nov 3, 2024
Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Nov 3, 2024

I've mocked the posterior sampling with the sample_prior_predictive for handful of the CLV tests that only check for input and output.
For instance, save and load. Should shave off some time in the CI


📚 Documentation preview 📚: https://pymc-marketing--1156.org.readthedocs.build/en/1156/

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (7a84c64) to head (ba679f9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1156   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          39       39           
  Lines        4063     4063           
=======================================
  Hits         3885     3885           
  Misses        178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@wd60622 wd60622 merged commit 59a35cb into main Nov 3, 2024
13 checks passed
@wd60622 wd60622 deleted the speed-up-slow-clv-tests branch November 3, 2024 22:37
@ColtAllen
Copy link
Collaborator

Thanks for speeding up the tests! Couldn't get around to reviewing this today, but these new test methods may be useful for my ongoing plotting PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants