Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional run of tests #1153

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Conditional run of tests #1153

merged 2 commits into from
Nov 3, 2024

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Nov 3, 2024 •
edited
Loading

This will have the tests run only if any of the files in the list have changed:

  • pyproject.toml
  • anything in pymc_marketing folder
  • anything in the tests

This would remove running tests if there are changes to other python files that might exist like in the scripts folder like in
#1147

📚 Documentation preview 📚: https://pymc-marketing--1153.org.readthedocs.build/en/1153/

@wd60622 wd60622 requested a review from juanitorduz November 3, 2024 16:16
juanitorduz
juanitorduz approved these changes Nov 3, 2024
View reviewed changes
Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! good call!

@juanitorduz juanitorduz merged commit 9ad47e7 into main Nov 3, 2024
7 of 8 checks passed
@juanitorduz juanitorduz deleted the conditional-run-of-tests branch November 3, 2024 19:20
@wd60622 wd60622 mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanitorduz juanitorduz juanitorduz approved these changes

Assignees
No one assigned
Labels
maintenance no releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wd60622 @juanitorduz