Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed equation in MMM docstring #1085

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Oct 16, 2024

The MMM linear model equation was not displaying correctly

@juanitorduz is varepsilon a typo and a math variable? Should it just be epsilon instead?

📚 Documentation preview 📚: https://pymc-marketing--1085.org.readthedocs.build/en/1085/

Check the rendering: https://pymc-marketing--1085.org.readthedocs.build/en/1085/api/generated/pymc_marketing.mmm.mmm.MMM.html#pymc_marketing.mmm.mmm.MMM

@wd60622 wd60622 added the docs Improvements or additions to documentation label Oct 16, 2024
@wd60622 wd60622 requested a review from juanitorduz October 16, 2024 21:03
@wd60622 wd60622 added the MMM label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (95bc1fa) to head (95084c6).
Report is 112 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files          39       39           
  Lines        4011     4011           
=======================================
  Hits         3833     3833           
  Misses        178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz
Copy link
Collaborator

juanitorduz commented Oct 17, 2024

I like varepsilon more haha https://tex.stackexchange.com/questions/98013/varepsilon-vs-epsilon

@juanitorduz juanitorduz merged commit d7a2383 into main Oct 17, 2024
13 checks passed
@juanitorduz juanitorduz deleted the fix-mmm-class-math branch October 17, 2024 08:27
@juanitorduz
Copy link
Collaborator

Thanks @wd60622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants