-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Hatchling build-backend and fix README for PyPI #1051
Conversation
This is much more reliable/robust/modern than setuptools
Not very familiar but logically makes sense |
Does pipx run hatch-fancy-pypi-readme have to be manually run again? |
Nope, the only thing that command does is to print a preview of the modified README to stdout. That command is useful for checking if the PyPI version of the README will come out as expected. |
Thanks @maresb ! Out of curiosity ... is this part of a plan to move to |
It's independent. The pixi stuff should not and will not touch Pixi does allow its config to be read from |
Ah I meant to link this. Here's what adding pixi looks like: pymc-labs/CausalPy#412 |
I think this PR is failing because an unrelated issue (mmm.save("model.nc") in the example notebook). I had commented that line before so I'll patch this again tonight) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
- Coverage 95.86% 95.60% -0.27%
==========================================
Files 39 39
Lines 3940 3934 -6
==========================================
- Hits 3777 3761 -16
- Misses 163 173 +10 ☔ View full report in Codecov by Sentry. |
Thanks @juanitorduz and @wd60622! All green now. |
Amazing! Thanks @maresb ! |
Description
See individual commits for a breakdown.
pip
andpython -m build
as normal.)The result of the regex can be previewed with
pipx run hatch-fancy-pypi-readme
and the diff isRelated Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--1051.org.readthedocs.build/en/1051/