Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed-Form PMFs for PPCs #878

Closed
ColtAllen opened this issue Jul 26, 2024 · 3 comments
Closed

Closed-Form PMFs for PPCs #878

ColtAllen opened this issue Jul 26, 2024 · 3 comments

Comments

@ColtAllen
Copy link
Collaborator

While working on the upcoming BetaGeoBetaBinomModel, I found a closed-form solution in the research paper for the model's probability mass function (PMF). After doing some more digging I realized every CLV model has a closed-form expression.

Currently the distribution_new_customers method builds these PMFs from scratch via sampling. However, it should be more performant for PPCs (both prior and posterior) to use the closed-form PMF expressions.

@ColtAllen
Copy link
Collaborator Author

@ricardoV94 this sampling convention began with ShiftedBeteGeoModelIndividual. Is there a reason why the PMF in the paper wasn't used? See equation(3):

https://faculty.wharton.upenn.edu/wp-content/uploads/2012/04/Fader_hardie_jim_07.pdf

@ColtAllen ColtAllen removed their assignment Jul 26, 2024
@ricardoV94
Copy link
Contributor

@ricardoV94 this sampling convention began with ShiftedBeteGeoModelIndividual. Is there a reason why the PMF in the paper wasn't used? See equation(3):

https://faculty.wharton.upenn.edu/wp-content/uploads/2012/04/Fader_hardie_jim_07.pdf

Sampling from a PMF is not trivial? I'm not sure what you're suggesting

@ColtAllen
Copy link
Collaborator Author

Closing this because the closed-form PMF expressions are quite complex to code out and test, and it's uncertain how much faster this would be compared to the current sampling approach, the code for which is at least clean, easily adaptable & testable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants