Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock posterior with prior for MMM tests #518

Open
wd60622 opened this issue Feb 7, 2024 · 3 comments
Open

mock posterior with prior for MMM tests #518

wd60622 opened this issue Feb 7, 2024 · 3 comments

Comments

@wd60622
Copy link
Contributor

wd60622 commented Feb 7, 2024

Follow up from #515 and #514

Goal:

  • don't call fit but use a mocked posterior for testing majority of the methods
  • call fit and check for convergence and mark test as slow
@ricardoV94
Copy link
Contributor

This is still relevant, we are spending 5 minutes (25% CI) setting up the fixtures for this test, just to check nothing crashes when we call the plot utilities: https://github.com/pymc-labs/pymc-marketing/actions/runs/8139313836/job/22242195431?pr=565#step:5:827

@wd60622
Copy link
Contributor Author

wd60622 commented Mar 8, 2024

I am going to pick up this issue

@wd60622
Copy link
Contributor Author

wd60622 commented Jun 19, 2024

Some were address. However others need to be changed as well tests for actual fits with mark of slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants