Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_new_data_sample_posterior_predictive_method takes 50 minutes (70%) of CI time #514

Closed
ricardoV94 opened this issue Feb 6, 2024 · 4 comments · Fixed by #515
Closed

test_new_data_sample_posterior_predictive_method takes 50 minutes (70%) of CI time #514

ricardoV94 opened this issue Feb 6, 2024 · 4 comments · Fixed by #515
Labels
maintenance MMM tests

Comments

@ricardoV94
Copy link
Contributor

ricardoV94 commented Feb 6, 2024 •
edited
Loading

I counted 35 parametrizations, each of which takes roughly 90 seconds long. This accounts for 50 minutes or 70% of the whole CI in this run:

https://github.com/pymc-labs/pymc-marketing/actions/runs/7771863902/job/21193663231?pr=506#step:5:872
@ricardoV94 ricardoV94 changed the title MMM Posterior predictive methods consume 25 minutes of CI time MMM Posterior predictive tests consume 25 minutes of CI time Feb 6, 2024
@ricardoV94
Copy link
Contributor Author

Somewhat related to #361

@ricardoV94 ricardoV94 changed the title MMM Posterior predictive tests consume 25 minutes of CI time test_new_data_sample_posterior_predictive_method takes 50 minutes of CI time Feb 6, 2024
@ricardoV94 ricardoV94 changed the title test_new_data_sample_posterior_predictive_method takes 50 minutes of CI time test_new_data_sample_posterior_predictive_method takes 50 minutes (70%) of CI time Feb 6, 2024
@ricardoV94
Copy link
Contributor Author

CC @wd60622

@wd60622
Copy link
Contributor

wd60622 commented Feb 6, 2024

Might be best to change the fixture scope. Maybe to session?
I think I didn't have it part of the class like the other tests

@ricardoV94
Copy link
Contributor Author

Perhaps! Worth a try

This was referenced Feb 6, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance MMM tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reuse fixtures in slow MMM tests
2 participants
@ricardoV94 @wd60622