Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tanh component #1303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix tanh component #1303

wants to merge 2 commits into from

Conversation

aseyboldt
Copy link

@aseyboldt aseyboldt commented Dec 20, 2024

@github-actions github-actions bot added MMM bug Something isn't working good first issue Good for newcomers labels Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (85f9016) to head (04f0db2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1303   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          43       43           
  Lines        4530     4530           
=======================================
  Hits         4305     4305           
  Misses        225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove beta default prior and beta from function signature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect implementation of tanh saturation in TanhSaturation component
2 participants